You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent changes to the CheckWithTypeResolutionMojo class in the Kotlin project have enhanced its ability to handle invalid input directories. The inputSkipLog function now accepts a list of invalid directories and logs them accordingly. The update also allows the check for multiple input directories separated by commas, thus improving the logging and handling of such cases.
Changes
File Path
Change Summary
.../CheckWithTypeResolutionMojo.kt
The inputSkipLog function has been modified to accept a list of invalid input directories and update the log message accordingly. The check for a single input directory has been replaced with a check for multiple input directories separated by commas.
Tips
Chat with CodeRabbit Bot (@coderabbitai)
If you reply to a review comment from CodeRabbit, the bot will automatically respond.
To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
Note: Review comments are made on code diffs or files, not on the PR overview.
Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai help to get help.
@coderabbitai resolve to resolve all the CodeRabbit review comments.
Note: For conversation with the bot, please use the review comments on code diffs or files.
CodeRabbit Configration File (.coderabbit.yaml)
You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json
…576)
for now, we can use the entire base directory as the input source for
detekt type resolution. [i've submitted a
change](Ozsie/detekt-maven-plugin#214) against
the `detekt-maven-plugin` we're using that will allow us to specify
multiple input sources. once this goes through we can be more granular
to explicitly use the source directory plus generated sources with the
following config:
`<input>${project.basedir}/src/main/kotlin,${project.build.directory}/generated-sources/ftl</input>`
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary by CodeRabbit